Compare commits

..

1 commit

Author SHA1 Message Date
58c2037443 TD-34: Solved comments made by reviewer
Some checks failed
Quality Check / Validate OAS (push) Successful in 36s
Quality Check / Validate OAS (pull_request) Successful in 37s
Quality Check / Testing (push) Successful in 1m16s
Quality Check / Static Analysis (push) Successful in 1m28s
Quality Check / Linting (push) Failing after 1m29s
Quality Check / Linting (pull_request) Failing after 1m4s
Quality Check / Static Analysis (pull_request) Successful in 1m12s
Quality Check / Testing (pull_request) Successful in 47s
2025-02-26 12:19:57 +01:00

View file

@ -65,14 +65,7 @@ public class AdminApiController implements AdminApi {
if (order == null) { if (order == null) {
order = GetAllPlayersConfigurationData.OrderEnum.DESCENDING; order = GetAllPlayersConfigurationData.OrderEnum.DESCENDING;
} }
Sort.Direction direction; Sort.Direction direction = order == GetAllPlayersConfigurationData.OrderEnum.ASCENDING ? Sort.Direction.ASC : Sort.Direction.DESC;
if (order == GetAllPlayersConfigurationData.OrderEnum.ASCENDING) {
direction = Sort.Direction.ASC;
} else {
direction = Sort.Direction.DESC;
}
Pageable pageable = PageRequest.of(page, pageSize, Sort.by(direction, sortBy)); Pageable pageable = PageRequest.of(page, pageSize, Sort.by(direction, sortBy));
Page<Player> playerPage; Page<Player> playerPage;
@ -83,8 +76,7 @@ public class AdminApiController implements AdminApi {
playerPage = playerRepository.findAll(pageable); playerPage = playerRepository.findAll(pageable);
} }
List<AdministratablePlayer> playersMapped = List<AdministratablePlayer> playersMapped = playerMapperService.mapPlayersToAdministratablePlayers(playerPage.getContent());
playerMapperService.mapPlayersToAdministratablePlayers(playerPage.getContent());
if (playersMapped.isEmpty()) { if (playersMapped.isEmpty()) {
return ResponseEntity.noContent().build(); return ResponseEntity.noContent().build();