Compare commits

..

1 commit

Author SHA1 Message Date
440160980d TD-34: Solved comments made by reviewer
Some checks failed
Quality Check / Validate OAS (push) Successful in 35s
Quality Check / Validate OAS (pull_request) Successful in 35s
Quality Check / Testing (push) Successful in 1m15s
Quality Check / Static Analysis (push) Successful in 1m25s
Quality Check / Linting (push) Failing after 1m51s
Quality Check / Linting (pull_request) Failing after 1m16s
Quality Check / Static Analysis (pull_request) Successful in 1m19s
Quality Check / Testing (pull_request) Successful in 51s
2025-02-26 12:32:04 +01:00

View file

@ -65,7 +65,14 @@ public class AdminApiController implements AdminApi {
if (order == null) {
order = GetAllPlayersConfigurationData.OrderEnum.DESCENDING;
}
Sort.Direction direction = order == GetAllPlayersConfigurationData.OrderEnum.ASCENDING ? Sort.Direction.ASC : Sort.Direction.DESC;
Sort.Direction direction;
if (order == GetAllPlayersConfigurationData.OrderEnum.ASCENDING) {
direction = Sort.Direction.ASC;
} else {
direction = Sort.Direction.DESC;
}
Pageable pageable = PageRequest.of(page, pageSize, Sort.by(direction, sortBy));
Page<Player> playerPage;
@ -76,7 +83,8 @@ public class AdminApiController implements AdminApi {
playerPage = playerRepository.findAll(pageable);
}
List<AdministratablePlayer> playersMapped = playerMapperService.mapPlayersToAdministratablePlayers(playerPage.getContent());
List<AdministratablePlayer> playersMapped =
playerMapperService.mapPlayersToAdministratablePlayers(playerPage.getContent());
if (playersMapped.isEmpty()) {
return ResponseEntity.noContent().build();