[Feature]: Registration Mask #1

Closed
SZUT-Dorian wants to merge 3 commits from td-29-registrierungsformular into trunk
Member

Ticket

TD-29

Beschreibung

The registration mask and its corresponding validation was implemented in this ticket.

Weitere Infos

You can use empty spaces for usernames - Bugfix ticket already written

### Ticket TD-29 ### Beschreibung The registration mask and its corresponding validation was implemented in this ticket. ### Weitere Infos You can use empty spaces for usernames - Bugfix ticket already written
SZUT-Dorian self-assigned this 2025-02-12 12:29:11 +00:00
SZUT-Mehdi was assigned by SZUT-Dorian 2025-02-12 12:29:11 +00:00
SZUT-Rajbir was assigned by SZUT-Dorian 2025-02-12 12:29:11 +00:00
SZUT-Dorian added 3 commits 2025-02-12 12:29:11 +00:00
TD-29: Player Registration Form implemented WIP: Empty spaces as login data
All checks were successful
Quality Check / Linting (push) Successful in 22s
d77dfb0526
TD-29: Player Registration Form implemented
All checks were successful
Quality Check / Linting (push) Successful in 22s
Quality Check / Linting (pull_request) Successful in 22s
a83a0c10cf
snoweuph requested changes 2025-02-12 12:43:59 +00:00
snoweuph left a comment
Owner

Bitte alle Aufgaben erledigen und die Commit Historie sinnvoll Squashen/rebasen

Bitte alle Aufgaben erledigen und die Commit Historie sinnvoll Squashen/rebasen
@ -3,4 +3,5 @@
<main>
<h1>{{title.getTitle()}}</h1>
<router-outlet />
<app-registration-form></app-registration-form>
Owner

Bitte im Dashboard laden und nicht unter der aktuellen Seite

Bitte im Dashboard laden und nicht unter der aktuellen Seite
SZUT-Dorian marked this conversation as resolved
@ -0,0 +1,19 @@
<div>
Owner

der Div ist unötig

der Div ist unötig
SZUT-Dorian marked this conversation as resolved
@ -0,0 +1,5 @@
.registration-container{
Owner

Der Klassenname sollte in Bang-Notation sein.
Hier also einfach registration-form

Der Klassenname sollte in Bang-Notation sein. Hier also einfach `registration-form`
SZUT-Dorian marked this conversation as resolved
@ -0,0 +1,23 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
Owner

Kann weg, wir schreiben keine Frontend Tests in diesem Projekt

Kann weg, wir schreiben keine Frontend Tests in diesem Projekt
SZUT-Dorian marked this conversation as resolved
@ -0,0 +33,4 @@
this.serverApi
.playerRegister(this.registrationForm.value)
.subscribe((response) => {
console.log(response);
Owner

console.log durch positives Feedback an den Nutzer austauschen

`console.log` durch positives Feedback an den Nutzer austauschen
SZUT-Dorian marked this conversation as resolved
SZUT-Dorian closed this pull request 2025-02-12 13:17:21 +00:00
snoweuph deleted branch td-29-registrierungsformular 2025-02-13 03:28:02 +00:00
All checks were successful
Quality Check / Linting (push) Successful in 22s
Required
Details
Quality Check / Linting (pull_request) Successful in 22s
Required
Details

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TowerDefence/Companion#1
No description provided.