From d77dfb0526a78ac86a28900adad8af9d525335ed Mon Sep 17 00:00:00 2001 From: Dorian Nemec Date: Wed, 12 Feb 2025 12:56:03 +0100 Subject: [PATCH] TD-29: Player Registration Form implemented WIP: Empty spaces as login data --- src/app/app.component.ts | 2 +- src/app/app.config.ts | 2 +- .../registration-form.component.spec.ts | 28 +++++++++---------- .../registration-form.component.ts | 19 ++++++------- .../views/dashboard/dashboard.component.ts | 1 - 5 files changed, 25 insertions(+), 27 deletions(-) diff --git a/src/app/app.component.ts b/src/app/app.component.ts index a7793bd..3c345ea 100644 --- a/src/app/app.component.ts +++ b/src/app/app.component.ts @@ -3,7 +3,7 @@ import { Title } from '@angular/platform-browser'; import { RouterOutlet } from '@angular/router'; import { HeaderComponent } from '@app/header/header.component'; import { NotificationBoxComponent } from '@app/notification-box/notification-box.component'; -import {RegistrationFormComponent} from "@app/registration-form/registration-form.component"; +import {RegistrationFormComponent} from '@app/registration-form/registration-form.component'; @Component({ diff --git a/src/app/app.config.ts b/src/app/app.config.ts index 6c56324..f47ecae 100644 --- a/src/app/app.config.ts +++ b/src/app/app.config.ts @@ -2,9 +2,9 @@ import {provideHttpClient} from '@angular/common/http'; import {ApplicationConfig, provideZoneChangeDetection} from '@angular/core'; import {provideAnimationsAsync} from '@angular/platform-browser/animations/async'; import {provideRouter} from '@angular/router'; +import {BASE_PATH, Configuration} from '@core/server'; import {routes} from './app.routes'; -import {BASE_PATH, Configuration} from "@core/server"; export const appConfig: ApplicationConfig = { providers: [ diff --git a/src/app/registration-form/registration-form.component.spec.ts b/src/app/registration-form/registration-form.component.spec.ts index c279480..a1068c3 100644 --- a/src/app/registration-form/registration-form.component.spec.ts +++ b/src/app/registration-form/registration-form.component.spec.ts @@ -3,21 +3,21 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { RegistrationFormComponent } from './registration-form.component'; describe('RegistrationFormComponent', () => { - let component: RegistrationFormComponent; - let fixture: ComponentFixture; + let component: RegistrationFormComponent; + let fixture: ComponentFixture; - beforeEach(async () => { - await TestBed.configureTestingModule({ - imports: [RegistrationFormComponent] - }) - .compileComponents(); + beforeEach(async () => { + await TestBed.configureTestingModule({ + imports: [RegistrationFormComponent] + }) + .compileComponents(); - fixture = TestBed.createComponent(RegistrationFormComponent); - component = fixture.componentInstance; - fixture.detectChanges(); - }); + fixture = TestBed.createComponent(RegistrationFormComponent); + component = fixture.componentInstance; + fixture.detectChanges(); + }); - it('should create', () => { - expect(component).toBeTruthy(); - }); + it('should create', () => { + expect(component).toBeTruthy(); + }); }); diff --git a/src/app/registration-form/registration-form.component.ts b/src/app/registration-form/registration-form.component.ts index f8d6d11..58bf327 100644 --- a/src/app/registration-form/registration-form.component.ts +++ b/src/app/registration-form/registration-form.component.ts @@ -1,12 +1,11 @@ import {Component} from '@angular/core'; -import {PlayerRegistrationData, ServerService} from "@core/server"; -import {MatFormFieldModule} from '@angular/material/form-field'; import {FormBuilder, FormGroup, FormsModule, ReactiveFormsModule} from '@angular/forms'; -import {MatSelectModule} from '@angular/material/select'; +import {MatButtonModule} from '@angular/material/button'; +import {MatFormFieldModule} from '@angular/material/form-field'; import {MatInputModule} from '@angular/material/input'; -import {MatButtonModule} from "@angular/material/button"; -import {NotificationService, NotificationType} from "@core/notification/notification.service"; -import {isEmpty, max} from "rxjs"; +import {MatSelectModule} from '@angular/material/select'; +import {NotificationService, NotificationType} from '@core/notification/notification.service'; +import {PlayerRegistrationData, ServerService} from '@core/server'; @Component({ selector: 'app-registration-form', @@ -21,15 +20,15 @@ export class RegistrationFormComponent { constructor(private serverApi: ServerService, private formBuilder: FormBuilder, private notifications: NotificationService) { this.registrationForm = this.formBuilder.group({ - username: "", - password: "", - }) + username: '', + password: '', + }); //this.registrationForm.addValidators(isEmpty); } registerPlayer() { if (!this.registrationForm.valid) { - this.notifications.publish("This form is invalid!", NotificationType.Error); + this.notifications.publish('This form is invalid!', NotificationType.Error); return; } this.serverApi diff --git a/src/app/views/dashboard/dashboard.component.ts b/src/app/views/dashboard/dashboard.component.ts index 6f6fb10..bd2d5c0 100644 --- a/src/app/views/dashboard/dashboard.component.ts +++ b/src/app/views/dashboard/dashboard.component.ts @@ -1,5 +1,4 @@ import {Component} from '@angular/core'; -import {ServerService} from "@core/server"; @Component({ selector: 'app-dashboard',