From dd369a54781b0a1991dda8f03bd14a2783977bb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20S=C3=A4ume?= <dominik.saeume@hmmh.de>
Date: Thu, 16 May 2024 18:30:50 +0200
Subject: [PATCH] NOTICKET: Fix MedicationDao

---
 .../hitec/nhplus/fixtures/MedicationFixture.java  |  6 ------
 .../nhplus/medication/database/MedicationDao.java | 15 ++++++++++++++-
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/main/java/de/hitec/nhplus/fixtures/MedicationFixture.java b/src/main/java/de/hitec/nhplus/fixtures/MedicationFixture.java
index fed7e20..8dc9f96 100644
--- a/src/main/java/de/hitec/nhplus/fixtures/MedicationFixture.java
+++ b/src/main/java/de/hitec/nhplus/fixtures/MedicationFixture.java
@@ -67,7 +67,6 @@ public class MedicationFixture implements Fixture<Medication> {
         Ingredient warfarinnatrium = new Ingredient("Warfarinnatrium");
 
         medications.add(new Medication(
-                1,
                 "Metformin",
                 "AstraZeneca",
                 List.of(
@@ -81,7 +80,6 @@ public class MedicationFixture implements Fixture<Medication> {
                 100
         ));
         medications.add(new Medication(
-                2,
                 "Lisinopril",
                 "Teva Pharmaceuticals",
                 List.of(
@@ -95,7 +93,6 @@ public class MedicationFixture implements Fixture<Medication> {
                 150
         ));
         medications.add(new Medication(
-                3,
                 "Simvastatin",
                 "Mylan",
                 List.of(
@@ -109,7 +106,6 @@ public class MedicationFixture implements Fixture<Medication> {
                 80
         ));
         medications.add(new Medication(
-                4,
                 "Enoxaparin",
                 "Sanofi",
                 List.of(
@@ -122,7 +118,6 @@ public class MedicationFixture implements Fixture<Medication> {
                 120
         ));
         medications.add(new Medication(
-                5,
                 "Levothyroxin",
                 "Sandoz",
                 List.of(
@@ -136,7 +131,6 @@ public class MedicationFixture implements Fixture<Medication> {
                 90
         ));
         medications.add(new Medication(
-                6,
                 "Warfarin",
                 "Apotex Inc.",
                 List.of(
diff --git a/src/main/java/de/hitec/nhplus/medication/database/MedicationDao.java b/src/main/java/de/hitec/nhplus/medication/database/MedicationDao.java
index 556a623..7397f8b 100644
--- a/src/main/java/de/hitec/nhplus/medication/database/MedicationDao.java
+++ b/src/main/java/de/hitec/nhplus/medication/database/MedicationDao.java
@@ -29,6 +29,7 @@ public class MedicationDao implements Dao<Medication> {
 
     @Override
     public void create(Medication medication) throws SQLException {
+        connection.setAutoCommit(false); //Switch to Manual Commit, to do an SQL Transaction
         final String medicationSQL = """
                     INSERT INTO medication
                     (name, manufacturer, possibleSideEffects, administrationMethod, currentStock)
@@ -42,6 +43,15 @@ public class MedicationDao implements Dao<Medication> {
         medicationStatement.setInt(5, medication.getCurrentStock());
         medicationStatement.execute();
 
+        ResultSet generatedKeys = connection.createStatement().executeQuery("SELECT last_insert_rowid()");
+        connection.commit(); //Finish SQL Transaction
+        connection.setAutoCommit(true); //Switch back Mode
+
+        if (!generatedKeys.next()) {
+            return;
+        }
+        int newId = generatedKeys.getInt(1);
+
         final String ingredientSQL = """
                     INSERT INTO medication_ingredient
                     (id, name)
@@ -49,7 +59,7 @@ public class MedicationDao implements Dao<Medication> {
                 """;
         for (Ingredient ingredient : medication.getIngredients()) {
             PreparedStatement ingredientStatement = this.connection.prepareStatement(ingredientSQL);
-            ingredientStatement.setInt(1, medication.getId());
+            ingredientStatement.setInt(1, newId);
             ingredientStatement.setString(2, ingredient.getName());
             ingredientStatement.execute();
         }
@@ -104,6 +114,9 @@ public class MedicationDao implements Dao<Medication> {
             lastMedicationId = currentMedicationId;
         }
         for (Medication medication : medications) {
+            if(!ingredientMap.containsKey(medication.getId())){
+                continue;
+            }
             medication.setIngredients(ingredientMap.get(medication.getId()));
         }