SZUT/ProjectManagmentTool
5
0
Fork 0
Code Issues Pull requests Releases Wiki Activity Actions

PMT-40: alle Projekte eines Bestimmten Mitarbeiters abfragen #18

Merged
SZUT-Dominik merged 4 commits from story/PMT-40-alle-projekte-eines-bestimmten into trunk 2024-10-24 09:02:40 +00:00
Conversation 0 Commits 4 Files changed 4 +10 -7
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6b430ae251 - Show all commits

17
src/main/java/de/hmmh/pmt/ApiController.java
View file

@ -241,16 +241,19 @@ public class ApiController implements DefaultApi {
@Override @Override
public ResponseEntity<EmployeeProjectsDTO> getAListOfAllProjectsFromASpecificEmployee(Long id) { public ResponseEntity<EmployeeProjectsDTO> getAListOfAllProjectsFromASpecificEmployee(Long id) {
ApiTools.CheckEmployeeRecord employeeRecord = apiTools.checkEmployeeExists(id);
if (employeeRecord.status() != HttpStatus.OK) {
return new ResponseEntity<>(employeeRecord.status());
SZUT-Rajbir marked this conversation as resolved Outdated
SZUT-Dominik commented 2024-10-23 20:36:29 +00:00
Outdated
Review
Copy link

Doppeltes anlegen des response DTOs.

Codeflow kann hier auf jedenfall verbessert werden

Doppeltes anlegen des response DTOs. Codeflow kann hier auf jedenfall verbessert werden
}
List<Allocation> allocationsByEmployee = allocationRepository.findAllByEmployeeId(id); List<Allocation> allocationsByEmployee = allocationRepository.findAllByEmployeeId(id);
Set<Project> projects = allocationsByEmployee.stream()
.map(Allocation::getProject)
.collect(Collectors.toSet());
EmployeeProjectsDTO response = new EmployeeProjectsDTO(); EmployeeProjectsDTO response = new EmployeeProjectsDTO();
for (Project project : projects) { response.setProjects(new ArrayList<>());
response.addProjectsItem(mapper.mapProject(project)); for (Allocation allocation : allocationsByEmployee) {
response.addProjectsItem(mapper.mapProject(allocation.getProject()));
} }
return new ResponseEntity<>(HttpStatus.OK);
return ResponseEntity.ok(response);
} }
} }