SZUT/ProjectManagmentTool
5
0
Fork 0
Code Issues Pull requests Releases Wiki Activity Actions

PMT-26 refactor try/catch getAListOfAllEmployeesFromASpecificProject
Some checks failed
Quality Check / Validate OAS (push) Successful in 33s
Details
Quality Check / Linting (push) Failing after 49s
Details
Quality Check / Static Analysis (push) Failing after 50s
Details
Quality Check / Testing (push) Failing after 51s
Details

Browse source
This commit is contained in:
Rajbir Singh 2024-10-22 15:50:36 +02:00
parent 9692f1f179
commit 94298293a8
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/main/java/de/hmmh/pmt/ApiController.java
View file

@ -159,14 +159,17 @@ public class ApiController implements DefaultApi {
.map(Allocation::getEmployeeId) .map(Allocation::getEmployeeId)
.collect(Collectors.toSet()); .collect(Collectors.toSet());
List<EmployeeResponseDTO> employees = apiClientFactory.getEmployeeApi().findAll1().stream() try {
.filter(employeeResponseDTO -> employeeIds.contains(employeeResponseDTO.getId())) List<EmployeeResponseDTO> employees = apiClientFactory.getEmployeeApi().findAll1().stream()
.toList(); .filter(employeeResponseDTO -> employeeIds.contains(employeeResponseDTO.getId()))
.toList();
return new ResponseEntity<>(employees, HttpStatus.OK);
} catch (RestClientException exception) {
return new ResponseEntity<>(HttpStatus.INTERNAL_SERVER_ERROR);
}
// Was wenn, die Liste der Allocation und die Liste der EmployeeResponseDTO nicht die gleiche Anzahl haben. // Was wenn, die Liste der Allocation und die Liste der EmployeeResponseDTO nicht die gleiche Anzahl haben.
// Das EmployeeResponseDTO wird vom EmployeeService gestellt, sollte man die Daten auf eigenes DTO mappen. // Das EmployeeResponseDTO wird vom EmployeeService gestellt, sollte man die Daten auf eigenes DTO mappen.
return new ResponseEntity<>(employees, HttpStatus.OK);
} }
} }