PMT-26 refactor try/catch getAListOfAllEmployeesFromASpecificProject

This commit is contained in:
Rajbir Singh 2024-10-22 15:50:36 +02:00 committed by Dominik Säume
parent 7cb75e449a
commit 89d383cc5d

View file

@ -169,14 +169,17 @@ public class ApiController implements DefaultApi {
.map(Allocation::getEmployeeId)
.collect(Collectors.toSet());
List<EmployeeResponseDTO> employees = apiClientFactory.getEmployeeApi().findAll1().stream()
.filter(employeeResponseDTO -> employeeIds.contains(employeeResponseDTO.getId()))
.toList();
try {
List<EmployeeResponseDTO> employees = apiClientFactory.getEmployeeApi().findAll1().stream()
.filter(employeeResponseDTO -> employeeIds.contains(employeeResponseDTO.getId()))
.toList();
return new ResponseEntity<>(employees, HttpStatus.OK);
} catch (RestClientException exception) {
return new ResponseEntity<>(HttpStatus.INTERNAL_SERVER_ERROR);
}
// Was wenn, die Liste der Allocation und die Liste der EmployeeResponseDTO nicht die gleiche Anzahl haben.
// Das EmployeeResponseDTO wird vom EmployeeService gestellt, sollte man die Daten auf eigenes DTO mappen.
return new ResponseEntity<>(employees, HttpStatus.OK);
}
}