PMT-27-code fix and cleanup Controller
This commit is contained in:
parent
8dff301457
commit
2ca9cfbadb
1 changed files with 4 additions and 17 deletions
|
@ -145,25 +145,12 @@ public class ApiController implements DefaultApi {
|
|||
|
||||
@Override
|
||||
public ResponseEntity<Void> removeEmployeeFromProject(Long id, Long employeeId){
|
||||
if (!projectRepository.existsById(id)) {
|
||||
return ResponseEntity.notFound().build();
|
||||
Optional<Allocation> allocation = allocationRepository.findById(new AllocationId(id, employeeId));
|
||||
if (allocation.isEmpty()){
|
||||
return new ResponseEntity<>(HttpStatus.NOT_FOUND);
|
||||
}
|
||||
|
||||
EmployeeResponseDTO employee;
|
||||
try {
|
||||
employee = apiClientFactory.getEmployeeApi().findById(employeeId);
|
||||
} catch (HttpClientErrorException exception) {
|
||||
return new ResponseEntity<>(exception.getStatusCode().equals(HttpStatus.NOT_FOUND)
|
||||
? HttpStatus.NOT_FOUND
|
||||
: HttpStatus.SERVICE_UNAVAILABLE);
|
||||
} catch (RestClientException exception) {
|
||||
return new ResponseEntity<>(HttpStatus.INTERNAL_SERVER_ERROR);
|
||||
}
|
||||
|
||||
Allocation allocation = allocationRepository.findById(id);
|
||||
if (allocation.getEmployeeId().equals(employeeId)) {
|
||||
allocationRepository.delete(allocation);
|
||||
}
|
||||
allocationRepository.delete(allocation.get());
|
||||
return new ResponseEntity<>(HttpStatus.NO_CONTENT);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue